Fix the test result output path for TemplateIntegrationTests #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
commented
Dec 24, 2024
| targetDir | ||
| "bin/Release/net6.0/Fake.DotNet.Cli.IntegrationTests.dll" | ||
| root | ||
| ("src" </> "test" </> "Fake.DotNet.Cli.IntegrationTests" </> "bin" </> "Release" </> "net6.0" </> "Fake.DotNet.Cli.IntegrationTests.dll") |
There was a problem hiding this comment.
I pulled the change out of a version of the .NET 8 branch, so it picked up the change to avoid hard coded path separators as well
xperiandri
approved these changes
Jan 8, 2025
xperiandri
force-pushed
the
TemplateIntegrationTests_path
branch
from
42ab2c8 to
6df8003
Compare
xperiandri
force-pushed
the
TemplateIntegrationTests_path
branch
from
6df8003 to
fcaed66
Compare
|
@Numpsy should any previous fixes or this be documented in the release notes? |
|
@xperiandri #2839 maybe? (this one is just in the tests) |
|
Yes, not very important for consumers but makes sense to mention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed when having a poke at the .NET 8 CI test failures that the 'Fake.DotNet.Cli.IntegrationTests' test results file isn't being published into the CI as the restults file is getting put under the integration tests folder rather than under the root results folder with the other 3 result xml files - so this is an attempt to fix that by using the same root results folder as the other test project runs